How to Fix a Failing Spec
Make sure you have read:
Then, follow these steps to fix a failing spec:
- Run
rake
to ensure that all CI specs are passing. - Run
bin/mspec spec/some/spec_file.rb
to confirm the spec fails. - Edit a file somewhere in Rubinius (probably under the kernel directory).
- Run
rake build
to build your change. - Run
bin/mspec spec/some/spec_file.rb
to see if your change makes the spec pass. - Repeat until your spec passes.
- Run
rake
to ensure there are no regressions. - Change directory to Rubinius root if not already there.
- Run
git status, git add, git commit
, etc. Any changes made to the spec files under the spec/ruby directory must be in a different commit from changes made to other Rubinius source code files. - Run
git format-patch origin
, which will extract commits that the current branch accumulated since the last pull from origin, or `git format-patch -N’, where N is the number (1, 2, etc.) of commits for which you want to generate patches. - Create a gist with your patch and link to it in a ticket on the issue tracker at http://github.com/evanphx/rubinius/issues. You can add multiple patches to one ticket.
When your patch is accepted by the Rubinius project, you’ll get a commit bit for the Rubinius repository. Let Evan know what your Github username is.